Skip to content

fix: count only canonical valid solved issues#1273

Closed
DragunovX16 wants to merge 1 commit into
entrius:testfrom
DragunovX16:fix/issue-1269-canonical-valid-solved
Closed

fix: count only canonical valid solved issues#1273
DragunovX16 wants to merge 1 commit into
entrius:testfrom
DragunovX16:fix/issue-1269-canonical-valid-solved

Conversation

@DragunovX16
Copy link
Copy Markdown

Summary

  • Move valid_solved_count so it increments only after same-account and one-issue-per-PR canonical checks pass.
  • Preserve solved credibility for non-canonical sibling issues while preventing them from satisfying the valid-solved eligibility gate.
  • Add regression coverage for seven sibling issues closed by one PR, and update related canonical-rule fixtures.

Related Issues

Fixes #1269

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Other (describe below)

Testing

  • Tests added/updated
  • Manually tested

Commands run:

.venv312/bin/python -m pytest tests/validator/issue_discovery/test_scan.py -q
.venv312/bin/python -m ruff check gittensor/validator/issue_discovery/scan.py tests/validator/issue_discovery/test_scan.py
.venv312/bin/python -m ruff format --check gittensor/validator/issue_discovery/scan.py tests/validator/issue_discovery/test_scan.py

Checklist

  • Code follows project style guidelines
  • Self-review completed
  • Changes are documented (if applicable)

@xiao-xiao-mao xiao-xiao-mao Bot added the bug Something isn't working label May 14, 2026
@anderdc
Copy link
Copy Markdown
Collaborator

anderdc commented May 19, 2026

Fix conflicts.

@anderdc
Copy link
Copy Markdown
Collaborator

anderdc commented May 20, 2026

Conflicts have stood for 12+ hours with no resolution. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Non-canonical one-issue-per-PR siblings still satisfy the valid-solved eligibility gate

2 participants